Re: Eliminate curl binary

From: Stepan Kasal <kasal@ucw.cz>
Date: Jun 3, 2008, 13:58 UTC
Message-ID: <20080603135851.GB17302@camelia.ucw.cz>
In-Reply-To: <20080603121332.GA16570@camelia.ucw.cz>

Hello again.

(Sorry for answering twice, I type quicker than I think.)

> On Tue, Jun 03, 2008 at 01:14:52PM +0200, Johan Herland wrote:
> > In the next version of Git (v1.5.6, currently in RC1), git-clone.sh has 
> > been replaced by a builtin C version (builtin-clone.c, part of the git

In that case, git.spec.in should not require curl. (A diff with proposed patch attached.)

That said, I do think that including Fedora-style spec files and other distribution-specific files into the tarball is a mistake.

Stepan Kasal

(FYI: I'm a Fedora developper, working for Red Hat.)

diff --git a/git.spec.in b/git.spec.in
index 97a26be..cd8e883 100644
--- a/git.spec.in
+++ b/git.spec.in
@@ -7,12 +7,12 @@ Summary:  	Core git tools
 License: 	GPL
 Group: 		Development/Tools
 URL: 		http://kernel.org/pub/software/scm/git/
-Source: 	http://kernel.org/pub/software/scm/git/%{name}-%{version}.tar.gz
-BuildRequires:	zlib-devel >= 1.2, openssl-devel, curl-devel, expat-devel, gettext  %{!?_without_docs:, xmlto, asciidoc > 6.0.3}
+Source: 	http://kernel.org/pub/software/scm/git/%{name}-%{version}.tar.bz2
+BuildRequires:	zlib-devel >= 1.2, openssl-devel, libcurl-devel, expat-devel, gettext  %{!?_without_docs:, xmlto, asciidoc > 6.0.3}
 BuildRoot:	%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
 
 Requires:	perl-Git = %{version}-%{release}
-Requires:	zlib >= 1.2, rsync, curl, less, openssh-clients, expat
+Requires:	zlib >= 1.2, rsync, less, openssh-clients, expat
 Provides:	git-core = %{version}-%{release}
 Obsoletes:	git-core <= 1.5.4.2
 Obsoletes:	git-p4