git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [StGit PATCH 0/4] Handle non-ASCII filenames

From
Karl Hasselström <kha@treskal.com>
Date
Jun 3, 2008, 09:27 UTC
Message-ID
<20080603092727.GA13132@diana.vm.bytemark.co.uk>
In-Reply-To
<b0943d9e0806030056x588474dcha3e14dd8dca952ba@mail.gmail.com>
On 2008-06-03 08:56:38 +0100, Catalin Marinas wrote:
Show 7 quoted lines
> On 02/06/2008, Karl Hasselström <kha@treskal.com> wrote:
>
> > I fixed the first problem, and while doing so noticed that a
> > nearby block of code had exactly the same bug. So I fixed that as
> > well.
>
> That was fast :-). thanks.

Jakub reported the bug right before I was about to start hacking anyway. :-)

Show 7 quoted lines
> >  Catalin, this should go on the stable branch, I believe. It
> >  probably warrants a new release too, since anyone rebasing
> >  patches past the point where the "Märchen" file was removed from
> >  git.git is going to hit the same bug Jakub did.
>
> Yes, it will go in both stable and master. There are some more
> patches on stable already, I'll try to release 0.14.3 this weekend.
Splendid. You can pull from my "stable" branch if you like.
> Is the new infrastructure affected? We haven't got to the point of
> converting "rebase" yet (doesn't have all the functionality it needs
> in the new infrastructure).

The problem wasn't actually about rebase. It was about mangling of diff-index and diff-files output in tree_status(). I think if one were to look closely, a largish number of commands would be found to be affected.

The new infrastructure won't have this problem, by virtue of not having any such calls yet. Plus, I try to use the -z flag whenever I can from the outset.

> BTW, I created a new lib.git.Branch class as the parent of
> lib.git.Stack and it takes care the extra things used when creating
> a new stack like setting parent and remote branches. I'll post the
> patches in the next few days.
Looking forward to it.
-- 
Karl Hasselström, kha@treskal.com
      www.treskal.com/kalle
Previous: Catalin Marinas
Message 18 of 18 in “[StGIT BUG] StGIT errors out on rebasing patch deleting file with Unicode filename”
  1. Jakub NarebskiJun 1, 2008
  2. Jakub NarebskiJun 2, 2008
  3. Catalin MarinasJun 2, 2008
  4. Jakub NarebskiJun 2, 2008
  5. Catalin MarinasJun 2, 2008
  6. Add rebase test for when upstream has deleted a non-ASCII fileKarl Hasselström, Jun 2, 2008
  7. 0/4 Handle non-ASCII filenamesKarl Hasselström, Jun 2, 2008
  8. 1/4 Add rebase test for when upstream has deleted a non-ASCII fileKarl Hasselström, Jun 2, 2008
  9. 2/4 Handle changed files with non-ASCII namesKarl Hasselström, Jun 2, 2008
  10. 3/4 Test for another filename quoting issue in tree_status()Karl Hasselström, Jun 2, 2008
  11. 4/4 Handle refresh of changed files with non-ASCII namesKarl Hasselström, Jun 2, 2008
  12. 0/4 Handle non-ASCII filenamesKarl Hasselström, Jun 3, 2008
  13. 1/4 Add rebase test for when upstream has deleted a non-ASCII fileKarl Hasselström, Jun 3, 2008
  14. 2/4 Handle changed files with non-ASCII namesKarl Hasselström, Jun 3, 2008
  15. 3/4 Test for another filename quoting issue in tree_status()Karl Hasselström, Jun 3, 2008
  16. 4/4 Handle refresh of changed files with non-ASCII namesKarl Hasselström, Jun 3, 2008
  17. Catalin MarinasJun 3, 2008
  18. Karl HasselströmJun 3, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.