git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] gitweb: fix "next" link on bottom of commit log page

From
Gerrit Pape <pape@smarden.org>
Date
May 29, 2008, 18:10 UTC
Message-ID
<20080529181003.1249.qmail@b35f4f9e60eb05.315fe32.mid.smarden.org>

When viewing a gitweb repository commit log, the "next" link at the top of the page works as expected, the "next" link on the bottom of the page has a=search instead of a=log and thus fails to get you to the next page. This commit replaces the bottom "next" link with the same links as shown at the top of the page.

The bad link was reported by Kai Blin through
 http://bugs.debian.org/481902
Signed-off-by: Gerrit Pape <pape@smarden.org>
---
 gitweb/gitweb.perl |    7 +------
 1 files changed, 1 insertions(+), 6 deletions(-)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 57a1905..f7b9ac2 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -4703,12 +4703,7 @@ sub git_log {
 		git_print_log($co{'comment'}, -final_empty_line=> 1);
 		print "</div>\n";
 	}
-	if ($#commitlist >= 100) {
-		print "<div class=\"page_nav\">\n";
-		print $cgi->a({-href => href(-replay=>1, page=>$page+1),
-			       -accesskey => "n", -title => "Alt-n"}, "next");
-		print "</div>\n";
-	}
+	git_print_page_nav('log','', $hash,undef,undef, $paging_nav);
 	git_footer_html();
 }
 
-- 
1.5.5.2
Next: Jakub Narebski
Message 1 of 5 in “gitweb: fix "next" link on bottom of commit log page”
  1. gitweb: fix "next" link on bottom of commit log pageGerrit Pape, May 29, 2008
  2. Jakub NarebskiMay 30, 2008
  3. Jakub NarebskiJun 2, 2008
  4. gitweb: Fix "next" link on bottom of pageJakub Narebski, Jun 2, 2008
  5. Gerrit PapeJun 2, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.