git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] builtin-fetch.c (store_updated_refs): Honor update_local_ref() return value

From
Dmitry V. Levin <ldv@altlinux.org>
Date
May 27, 2008, 20:53 UTC
Message-ID
<20080527205348.GC32722@wo.int.altlinux.org>

Sync with builtin-fetch--tool.c where append_fetch_head() honors update_local_ref() return value.

This fixes git-fetch exit status,
http://bugzilla.altlinux.org/show_bug.cgi?id=15037
---
 builtin-fetch.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/builtin-fetch.c b/builtin-fetch.c
index 167f948..db60966 100644
--- a/builtin-fetch.c
+++ b/builtin-fetch.c
@@ -292,7 +292,7 @@ static int store_updated_refs(const char *url, struct ref *ref_map)
 {
 	FILE *fp;
 	struct commit *commit;
-	int url_len, i, note_len, shown_url = 0;
+	int rc = 0, url_len, i, note_len, shown_url = 0;
 	char note[1024];
 	const char *what, *kind;
 	struct ref *rm;
@@ -359,7 +359,7 @@ static int store_updated_refs(const char *url, struct ref *ref_map)
 			note);
 
 		if (ref)
-			update_local_ref(ref, what, verbose, note);
+			rc |= update_local_ref(ref, what, verbose, note);
 		else if (verbose)
 			sprintf(note, "* %-*s %-*s -> FETCH_HEAD",
 				SUMMARY_WIDTH, *kind ? kind : "branch",
@@ -376,7 +376,7 @@ static int store_updated_refs(const char *url, struct ref *ref_map)
 		}
 	}
 	fclose(fp);
-	return 0;
+	return rc;
 }
 
 /*
-- 
ldv
Next: Junio C Hamano
Message 1 of 3 in “builtin-fetch.c (store_updated_refs): Honor update_local_ref() return value”
  1. builtin-fetch.c (store_updated_refs): Honor update_local_ref() return valueDmitry V. Levin, May 27, 2008
  2. Junio C HamanoMay 28, 2008
  3. builtin-fetch.c (store_updated_refs): Honor update_local_ref() return valueDmitry V. Levin, May 28, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.