Re: [PATCH] hg-to-git: add --verbose option
On Monday 26 May 2008, Johannes Schindelin wrote:
Show 9 quoted lines
> This patch adds an option to make hg-to-git quiet by default. Note:
> it only suppresses those messages that would be printed when
> everything was up-to-date.
>
> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> ---
>
> Yeah, I know, a Python hater codes in Python. Well, somebody told
> me I had to code in it until I do not hate it anymore.
Show 20 quoted lines
> contrib/hg-to-git/hg-to-git.py | 18 +++++++++++++-----
> 1 files changed, 13 insertions(+), 5 deletions(-)
>
> diff --git a/contrib/hg-to-git/hg-to-git.py
> b/contrib/hg-to-git/hg-to-git.py index d72ffbb..daad399 100755
> --- a/contrib/hg-to-git/hg-to-git.py
> +++ b/contrib/hg-to-git/hg-to-git.py
> @@ -46,6 +46,7 @@ options:
> for incrementals
> -n, --nrepack=INT: number of changesets that will trigger
> a repack (default=0, -1 to deactivate)
> + -v, --verbose: be verbose
>
> required:
> hgprj: name of the HG project to import (directory)
> @@ -75,15 +76,18 @@ def getgitenv(user, date):
>
> state = ''
> opt_nrepack = 0
> +verbose = ''
Maybe this should be
verbose = false
since it indicates your intent to exclusively use this variable as a
boolean.
The rest is ok, AFAICS.
Have fun! :)
...Johan
--
Johan Herland, <johan@herland.net>
www.herland.net
Johan Herland <johan@herland.net>