Re: [RFC/PATCH] gitweb: Paginate project list
- From
Jakub Narebski <jnareb@gmail.com>
- Date
- May 11, 2008, 23:51 UTC
- Message-ID
- <200805120151.20741.jnareb@gmail.com>
- In-Reply-To
- <1210485210.11526.145.camel@localhost.localdomain>
On Sun, 11 May 2008, J.H. wrote:
Show 13 quoted lines
> > On Sun, 2008-05-11 at 00:32 +0200, Jakub Narebski wrote: >> On Sun, 10 May 2008, J.H. <warthog19@eaglescrag.net> wrote: >> >> BTW. why do you think that kernel.org would be better to have project >> list pagination turned off? > > If we have caching on I'd rather leave it as a single page, much easier > to search on and with firefox /<project or name> then <ctrl>+g a couple > of times is really fast to find what I need. Also means less to cache > (good for us) and faster access for most. I'm going to guess leaving it > as a single page, unless it gets *very* unwieldy, will be how we leave > it.
First, you can cache individual pages of projects list output with small overhead if number of projects per page is large enough. Second, see my earlier patch adding project search capability to gitweb (it is server-side search, though). Searching needs caching data, not output, while pagination only can be done with both.
As to single-page projects list being being unwieldy... You should take into account how large the page is (having page size in megabytes isn't too good), how much time it takes to download (and not only generate), and how much time it takes for web browser to render it.
How many repositories is "too many", that I'm not sure about...
Show 13 quoted lines
>>> It might also be advantageous to generate the entire list and stash that >>> somewhere, (session on the host side?) and run the pagination out of >>> that. >> >> First, when using $projectslist file with new (second patch in series, >> "gitweb: Allow project description in project_index file" most of data >> (well, all except age) would be filled by parsing single file. >> >> Second, the idea is to cache results of filled in @$projlist e.g. using >> Storable, i.e. cache Perl data and not final HTML output. > > I approve of that plan, caching all the html is kinda expensive *hides > the 20G of gitweb cache he has*
Caching output (HTML) has the advantage of being simple, and avoiding time to generate page. Caching data has the advantage of taking less disk space due to being able to reuse the same data for different pages.
-- Jakub Narebski Poland