Re: [PATCH] Pay attention to GIT_DIR when searching the git directory
- From
- Jörg Sommer <joerg@alea.gnuu.de>
- Date
- May 5, 2008, 15:30 UTC
- Message-ID
- <20080505153029.GA12733@alea.gnuu.de>
- In-Reply-To
- <m3r6cg6dur.fsf@localhost.localdomain>
Hi Jakub,
Jakub Narebski schrieb am Mon 05. May, 07:10 (-0700):
Show 12 quoted lines
> Jörg Sommer <joerg@alea.gnuu.de> writes: > > Johannes Schindelin schrieb am Mon 05. May, 12:36 (+0100): > > > > If you do not say _what_ is affected by the change, you only confuse > > > the readers. > > > > Do you want something like “initialization: Pay attention to GIT_DIR when > > searching the git directory”? > > I think the idea was to use > "contrib/hooks/setgitperms: Use GIT_DIR if set" > or something like that.
Well, if this is the prefered form, I'll use it. But I don't like it, because the affected file is a piece of information that's already in the commit object. And it makes the :/ syntax useless, because in a series of commits all commits start with the same string: the filename. Thirdly, in gitk I've the problem that the space is very limited (because of my screen) and it is very annoying to see the same string at the begin of every commit message, especially when I've filtered for one file.
> > Is there a document with guidelines for commit messages, e.g. write the > > first letter upper or lower case? > > There are a few unwritten conventions.
Are there any plans to write them down?
Should I resend the patch or can Junio fix the commit message? I would take your suggestion.
Bye, Jörg.
-- Geld allein macht nicht glücklich, aber es ist besser in einem Taxi zu weinen, als in der Straßenbahn. (Marcel Reich‐Ranicki)