Re: [PATCH 0/3] log --graph and rev-list --graph

From: Adam Simpkins <adam@adamsimpkins.net>
Date: May 5, 2008, 06:19 UTC
Message-ID: <20080505061940.GA26319@adamsimpkins.net>
In-Reply-To: <46dff0320805041913t31c05a36w92be4a81a3da07af@mail.gmail.com>

On Mon, May 05, 2008 at 10:13:43AM +0800, Ping Yin wrote:

Show 8 quoted lines

> 
> Is the indention between ba7f5b and 38254 intentional?
> 
> * ba7f5b log and rev-list: add --graph option
> *   38254 Add history graph API
> *   12918 revision API: split parent rewriting
> *   c697a Cleanup xread() loops to use read_in_full()
> M     47179 Merge branch 'maint'

It's not really intentional, it's just the result of a rather simplistic computation.

The amount of horizontal padding used for each commit is computed as (2 * number of incoming columns from the previous commit) + (2 * number of parents of the current commit). This always results in enough padding. However, if the current commit is a child of one of the incoming columns, it results in 2 more spaces than necessary.

There's a comment in graph_pad_horizontally() graph.c that describes this behavior:

     * This computation results in 3 extra spaces to the right in most
     * cases, but only 1 extra space if the commit doesn't have any
     * children that have already been displayed in the graph (i.e.,
     * if the current commit isn't in graph->columns).

It could easily be fixed by performing an extra pass over the columns to check if any of the existing columns refers to the current commit.

I'll try to come up with a patch when I get the chance.

-- 
Adam Simpkins
adam@adamsimpkins.net