Re: [PATCH 3/3] diff: make "too many files" rename warning optional

From: Jeff King <peff@peff.net>
Date: May 4, 2008, 19:23 UTC
Message-ID: <20080504192332.GB13029@sigill.intra.peff.net>
In-Reply-To: <481CA227.1000801@ramsay1.demon.co.uk>

On Sat, May 03, 2008 at 06:34:31PM +0100, Ramsay Jones wrote:

Show 24 quoted lines

> This will also fix the problem I had with gitk on cygwin; namely "gitk
> --all &" on my "git" repo pops up an error dialog (see below), after
> which the diff display disappears.
> 
> The error dialog shows:
> --- >8 ---
> warning: too many files, skipping inexact rename detection
> warning: too many files, skipping inexact rename detection
>     while executing
> "close $bdf"
>     (procedure "getblobdiffline" line 89)
>     invoked from within
> "getblobdiffline file102daa00 1d6aeb410dc19893adbc0209bcf859f35ff1c7d6"
>     ("eval" body line 1)
>     invoked from within
> "eval $script"
>     (procedure "dorunq" line 9)
>     invoked from within
> "dorunq"
>     ("after" script)
> --- 8< ---
> 
> The git command issued by gitk appears to be:
>    git diff-tree -r -p -C --no-commit-id -U3 1d6aeb410dc19893adbc0209bcf859f35ff1c7d6

Hrm. Is gitk on cygwin somehow squishing stderr and stdout together? Or does gitk in general look at what happens on stderr?

Because while I am happy that removing this message fixes your problem, it is a little disconcerting to think that we can break gitk just by issuing a warning diagnostic on stderr.

-Peff