Re: [PATCH] Simplify and fix --first-parent implementation
- From
Jeff King <peff@peff.net>
- Date
- Apr 26, 2008, 12:27 UTC
- Message-ID
- <20080426122741.GA32457@sigill.intra.peff.net>
- In-Reply-To
- <20080426115956.GB19558@cuci.nl>
On Sat, Apr 26, 2008 at 01:59:56PM +0200, Stephen R. van den Berg wrote:
> >Please also sign your patch. > > Just with git-commit -s ? Or do I need to get gpg involved?
With git-commit -s; check out Documentation/SubmittingPatches.
> P.S. No reaction on the other patches means that they're accepted, or do > I need to resubmit them as well (signed)?
I for one would have liked to see more explanation on your "check for circular references" patch. I am not clear on what circumstances create such circular references.
-Peff