Re: Git on Windows, CRLF issues

From: Jeff King <peff@peff.net>
Date: Apr 23, 2008, 10:58 UTC
Message-ID: <20080423105838.GA15310@sigill.intra.peff.net>
In-Reply-To: <alpine.DEB.1.00.0804231110080.4181@eeepc-johanness>

On Wed, Apr 23, 2008 at 11:13:27AM +0100, Johannes Schindelin wrote:

Show 9 quoted lines

> > It was easy enough to work up the patch below, which allows
> > 
> >   git filter-branch --blob-filter 'tr a-z A-Z'
> > 
> > However, it's _still_ horribly slow.
> 
> You create a quite huge blob-cache, so you are pretty heavy on disk-I/O.  
> Have you tried (as suggested in the man page) to run this on a huge RAM 
> disk?  That should blow you away.

No, I didn't. But the disk I/O is pretty minimal. The blob cache is only a few megabytes, and it stays entirely in Linux's disk cache. My disk light only blinks every 5-10 seconds to flush dirty pages to disk.

Show 5 quoted lines

> I hoped that the rewrite-commits attempt was more than just that: an 
> attempt.  So there is a point you could start from, doing things in C.
>
> But I doubt that you get any joy: either your language is too limited, or 
> you will get the same problems (fork() overhead) again.

Ah, right. I totally forgot about that effort. I will take a peek next time I need to do some filtering.

Show 6 quoted lines

> > Anyway, here is the patch. I don't know if it is even worth applying, 
> > since it is still painfully slow.
> 
> I like your patch:
> 
> Acked-by: Johannes Schindelin <johannes.schindelin@gmx.de>

I think it could use some documentation updates. Avery, do you want to try adding a CRLF example to the manpage?

-Peff