Re: [PATCH] completion: remove use of dashed git commands
Dan McGee <dpmcgee@gmail.com> wrote:
> Signed-off-by: Dan McGee <dpmcgee@gmail.com>
> ---
> contrib/completion/git-completion.bash | 8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
Acked-by: Shawn O. Pearce <spearce@spearce.org>
Despite Dscho's remarks, this is a change that is harmless and
should be happening before we officially remove the dashed forms
from the user's path.
Show 43 quoted lines
> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
> index 4d81963..3f78630 100755
> --- a/contrib/completion/git-completion.bash
> +++ b/contrib/completion/git-completion.bash
> @@ -152,7 +152,7 @@ __git_heads ()
> done
> return
> fi
> - for i in $(git-ls-remote "$1" 2>/dev/null); do
> + for i in $(git ls-remote "$1" 2>/dev/null); do
> case "$is_hash,$i" in
> y,*) is_hash=n ;;
> n,*^{}) is_hash=y ;;
> @@ -173,7 +173,7 @@ __git_tags ()
> done
> return
> fi
> - for i in $(git-ls-remote "$1" 2>/dev/null); do
> + for i in $(git ls-remote "$1" 2>/dev/null); do
> case "$is_hash,$i" in
> y,*) is_hash=n ;;
> n,*^{}) is_hash=y ;;
> @@ -200,7 +200,7 @@ __git_refs ()
> done
> return
> fi
> - for i in $(git-ls-remote "$dir" 2>/dev/null); do
> + for i in $(git ls-remote "$dir" 2>/dev/null); do
> case "$is_hash,$i" in
> y,*) is_hash=n ;;
> n,*^{}) is_hash=y ;;
> @@ -223,7 +223,7 @@ __git_refs2 ()
> __git_refs_remotes ()
> {
> local cmd i is_hash=y
> - for i in $(git-ls-remote "$1" 2>/dev/null); do
> + for i in $(git ls-remote "$1" 2>/dev/null); do
> case "$is_hash,$i" in
> n,refs/heads/*)
> is_hash=y
> --
> 1.5.5
> --
Shawn.
Shawn O. Pearce <spearce@spearce.org>