Re: [PATCH (try 3)] http.c: 'use_git_config_string' on configuration options.

From

Christian Couder <chriscool@tuxfamily.org>

Date

Apr 20, 2008, 04:06 UTC

Message-ID

<20080420060629.38407fe1.chriscool@tuxfamily.org>

In-Reply-To

<480A7499.1040705@gmail.com>

> Signed-off-by: Guillermo O. Freschi <tordek@tordek.com.ar>
> ---
> My apologies, I had made a mistake on the previous attempt.
>
>   http.c |   36 ++++++++++++------------------------
>   1 files changed, 12 insertions(+), 24 deletions(-)
>
> diff --git a/http.c b/http.c
> index 256a5f1..8ae6432 100644
> --- a/http.c
> +++ b/http.c
> @@ -13,14 +13,14 @@ static CURL *curl_default;
>   char curl_errorstr[CURL_ERROR_SIZE];

   ^
There is one spurious whitespace before "char" in the above line.

>   static int curl_ssl_verify = -1;

   ^
In the above line too.

> -static char *ssl_cert = NULL;
> +static const char *ssl_cert = NULL;

These 2 lines above are fine.

>   #if LIBCURL_VERSION_NUM >= 0x070902

   ^
Here again there is one spurious whitespace.

[...]

>   static long curl_low_speed_time = -1;
>   static int curl_ftp_no_epsv = 0;
> @@ -100,39 +100,27 @@ static int http_options(const char *var, const 
> char *value)

"char *value)" should have stayed on the same line as "http_options(const char *var, const ".

Please try to send yourself your own patch and try to apply it using "git am", before you send it to the list.