git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[StGit PATCH 2/5] Use hardcoded author and committer names in tests

From
Karl Hasselström <kha@treskal.com>
Date
Apr 17, 2008, 21:12 UTC
Message-ID
<20080417211253.12809.71209.stgit@yoghurt>
In-Reply-To
<20080417210137.12809.88457.stgit@yoghurt>

There seems to be no reason for these to stay commented out -- in fact, commit v0.12-4-g5cd9e87 which introduced these lines seems to have left them commented out by mistake.

Signed-off-by: Karl Hasselström <kha@treskal.com>
---
 t/test-lib.sh |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/t/test-lib.sh b/t/test-lib.sh
index 2d12f1b..5e4c7a1 100644
--- a/t/test-lib.sh
+++ b/t/test-lib.sh
@@ -20,11 +20,11 @@ unset COMMIT_AUTHOR_NAME
 unset EMAIL
 unset GIT_ALTERNATE_OBJECT_DIRECTORIES
 unset GIT_AUTHOR_DATE
-#GIT_AUTHOR_EMAIL=author@example.com
-#GIT_AUTHOR_NAME='A U Thor'
+GIT_AUTHOR_EMAIL=author@example.com
+GIT_AUTHOR_NAME='A U Thor'
 unset GIT_COMMITTER_DATE
-#GIT_COMMITTER_EMAIL=committer@example.com
-#GIT_COMMITTER_NAME='C O Mitter'
+GIT_COMMITTER_EMAIL=committer@example.com
+GIT_COMMITTER_NAME='C O Mitter'
 unset GIT_DIFF_OPTS
 unset GIT_DIR
 unset GIT_EXTERNAL_DIFF
Previous: Karl HasselströmNext: Karl Hasselström
Message 3 of 7 in “test suite update”
  1. 0/5 test suite updateKarl Hasselström, Apr 17, 2008
  2. 1/5 If a patch is not changed when pushing, reuse the same commit objectKarl Hasselström, Apr 17, 2008
  3. 2/5 Use hardcoded author and committer names in testsKarl Hasselström, Apr 17, 2008
  4. 3/5 Steal more test-lib.sh updates from gitKarl Hasselström, Apr 17, 2008
  5. 4/5 Get rid of backticks in test-lib.shKarl Hasselström, Apr 17, 2008
  6. 5/5 Use test_cmp instead of diff -u in the test suiteKarl Hasselström, Apr 17, 2008
  7. Karl HasselströmApr 17, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.