gitweb: pathinfo feature breaks commitdiff/raw links

From: martin f krafft <madduck@madduck.net>
Date: Apr 17, 2008, 09:23 UTC
Message-ID: <20080417092339.GA17016@piper.oerlikon.madduck.net>

Hello,

as per suggestion in gitweb.cgi, I put the following into my gitweb.conf:

  $feature{'pathinfo'}{'default'} = [1];

This mostly works, but James Vega recently found a corner case where this is broken: the raw link of a commitdiff page, such as

  http://git.madduck.net/v/code/mailplate.git?a=commitdiff;h=f7d2365ee0ab439217083dd613daa4757a4e3d6e

suddenly becomes

  http://git.madduck.net/v/ARRAY(0xbc3b70)?a=commitdiff_plain;h=f7d2365ee0ab439217083dd613daa4757a4e3d6e
                           ^^^^^^^^^^^^^^^
when the feature is turned on. It works when it's off.

I discussed this a bit on IRC, with the following bottom line:

  < jengelh> if you see ARRAY... in the url, and [1] in the source
  the wise Perl person says "ah, of course"

Unfortunately, I am neither wise nor a Perl person, so I resort to just pointing this out to you and can offer to test any patches on this live server.

Cheers,

-- 
martin | http://madduck.net/ | http://two.sentenc.es/
 
"it is only the modern that ever becomes old-fashioned." 
                                                        -- oscar wilde
 
spamtraps: madduck.bogus@madduck.net