Re: StGit: kha/{stable,safe,experimental} updated

From: Karl Hasselström <kha@treskal.com>
Date: Apr 14, 2008, 08:11 UTC
Message-ID: <20080414081139.GB9135@diana.vm.bytemark.co.uk>
In-Reply-To: <20080414070348.GA9135@diana.vm.bytemark.co.uk>

On 2008-04-14 09:03:48 +0200, Karl Hasselström wrote:

> Though I was under the impression that I'd tested it with a fully
> applied stack ... I guess the test suite needs an addition or two.

The real proble turned out to be a certain developer who remembers running the test suite before pushing out his branches, even though no such thing occurred. Ahem.

This fixes the bug for me; I'll be squashing it into one of the other patches tonight. Sorry for the breakage.

diff --git a/stgit/lib/log.py b/stgit/lib/log.py
index 083a546..1830cbd 100644
--- a/stgit/lib/log.py
+++ b/stgit/lib/log.py
@@ -84,7 +84,7 @@ class Log(object):
         def pl(name):
             patches = [x.split() for x in
                        self.commit.data.tree.data.entries[name][1]
-                       .data.str.strip().split('\n')]
+                       .data.str.strip().split('\n') if x]
             # TODO: handle case where we don't have the commit object.
             return ([pn for sha1, pn in patches],
                     dict((pn, repo.get_commit(sha1)) for sha1, pn in patches))

-- 
Karl Hasselström, kha@treskal.com
      www.treskal.com/kalle