Re: [StGit PATCH] Remove broken branch creation subtest

From: Karl Hasselström <kha@treskal.com>
Date: Apr 13, 2008, 06:02 UTC
Message-ID: <20080413060223.GA27382@diana.vm.bytemark.co.uk>
In-Reply-To: <7vabjzhrsa.fsf@gitster.siamese.dyndns.org>

On 2008-04-12 11:06:13 -0700, Junio C Hamano wrote:

Show 13 quoted lines

> You got me worried here.
>
>  * "git show-ref" issues "error: refs/heads/foo points nowhere!" in all
>    cases, which is not bad.
>
>  * broken foo does not prevent "git show-ref" (no patterns) from carrying
>    out its primary task.  It goes on showing others.  There is no bad here
>    either.
>
>  * "git show-ref refs/heads/foo" errors out with 1, which is Ok.
>
>  * "git show-ref master" shows all the ones ending with "master", exits
>    with 0, which is Ok.

Sorry for making you all worried, when I could have tested this behavior myself and saved you the trouble ...

> It may be worth fixing the test than working it around, if only
> cleaning up is the issue.

Yes, that does seem more constructive. Will try to whip up a replacement patch later today.

Thanks for the review.

-- 
Karl Hasselström, kha@treskal.com
      www.treskal.com/kalle