Re: [PATCH] Add two core.sharedRepository options: group-readable and world-readable
- From
- Heikki Orsila <shdl@zakalwe.fi>
- Date
- Apr 12, 2008, 12:01 UTC
- Message-ID
- <20080412120159.GC31039@zakalwe.fi>
- In-Reply-To
- <7vzlrzlluj.fsf@gitster.siamese.dyndns.org>
On Fri, Apr 11, 2008 at 09:48:36PM -0700, Junio C Hamano wrote:
Show 16 quoted lines
> Heikki Orsila <shdl@zakalwe.fi> writes: > > > On Fri, Apr 11, 2008 at 05:53:36PM -0700, Junio C Hamano wrote: > > ... > >> For example, you may want to enforce "ug+rw,o=" in a repository. How > >> would you do that? > > > > Isn't that PERM_GROUP? The user always keeps u+rw for oneself. > > My question was about the "o=" part. I did not see you dropping bits for > others in your patch. > > And if your answer is "the user should have xx7 umask", that defeats the > whole point of your patch, as you are trying to dissociate the umask used > by the user for his usual task and enforce particular permission policy > for the repository.
You're correct. There are two options, do you have a preference on this matter?
1. current method + mask off others when needed
2. core.sharedRepository=0xxx
I think I like option 2 better (preserving backwards compatibility of course).
-- Heikki Orsila Barbie's law: heikki.orsila@iki.fi "Math is hard, let's go shopping!" http://www.iki.fi/shd