git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] test suite: remove useless TERM cruft in "t7005-editor.sh"

From
Christian Couder <chriscool@tuxfamily.org>
Date
Apr 6, 2008, 17:08 UTC
Message-ID
<20080406190850.e7a13c3c.chriscool@tuxfamily.org>

In commit 15387e32ff5116b82d3fe53df55b8c87eec83e01 I added some cruft to reset TERM to its previous value before the "test_done" at the end of "t7005-editor.sh" because otherwise "test_done" would have printed the test result with a bad TERM env variable (this resulted in output with no color on konsole).

But since commit c2116a1783a3d555d41892ae7db0dd0934d4ddf1 colored output is printed in a subshell with TERM reset to its original value so the cruft added in my patch above is now useless.

Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
---
 t/t7005-editor.sh |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/t/t7005-editor.sh b/t/t7005-editor.sh
index 6a74b3a..2d919d6 100755
--- a/t/t7005-editor.sh
+++ b/t/t7005-editor.sh
@@ -4,8 +4,6 @@ test_description='GIT_EDITOR, core.editor, and stuff'
 
 . ./test-lib.sh
 
-OLD_TERM="$TERM"
-
 for i in GIT_EDITOR core_editor EDITOR VISUAL vi
 do
 	cat >e-$i.sh <<-EOF
@@ -116,6 +114,4 @@ test_expect_success 'core.editor with a space' '
 
 '
 
-TERM="$OLD_TERM"
-
 test_done
-- 
1.5.5.rc2.20.g03f57.dirty
Message 1 of 1 in “test suite: remove useless TERM cruft in "t7005-editor.sh"”
  1. test suite: remove useless TERM cruft in "t7005-editor.sh"Christian Couder, Apr 6, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.