Re: [PATCH] alias.c: use git_config_string() to get alias_val

From: Christian Couder <chriscool@tuxfamily.org>
Date: Apr 6, 2008, 13:29 UTC
Message-ID: <200804061529.24083.chriscool@tuxfamily.org>
In-Reply-To: <20080406110232.GA6965@leksak.fem-net>

Le dimanche 6 avril 2008, Stephan Beyer a écrit :

Show 26 quoted lines

> Hi,
>
> > So you should say in the commit message that you decided to cast to
> > "const char **" despite what is on the Janitor page, and most
> > importantly explain why in the commit message.
>
> Ah, ok.
> Didn't knew that such reasoning goes into the commit message,
> but, yes, it makes sense.
>
> > > But instead of doing that, the original should be kept, because it is
> > > better in code beauty, performance and memory usage. ;-)
> >
> > Yes, so perhaps it's not a good idea to convert the original file to
> > git_config_string.
>
> Or to use the cast. ;-)
>
> [...]
>
> > But I don't think it's worth the trouble.
>
> I agree ;-)
>
> So what to do?
> Keep it?

No, I think its better to do nothing on "alias.c".

> And there are still some easy `Janitor tasks', like in builtin-apply.c:

Yes. And thanks, your patch looks good, but please send a proper patch for it latter if you really care about it.

(By proper I mean in its own email and not attached. And I know my patch included in my previous email was bad (corrupted tab, sorry about that, and not in its own email), but it was only for discussion, yours too granted.)

Now I think that you should focus on your GSoC application as you don't have much time left to improve it and I just asked you for more information.

Thanks, Christian.