Re: [PATCH (BUGFIX)] gitweb: Fix "Use of uninitialized value" error in 'history' view

From: Gerrit Pape <pape@smarden.org>
Date: Apr 5, 2008, 16:43 UTC
Message-ID: <20080405164303.30566.qmail@47fa24fd520dbf.315fe32.mid.smarden.org>
In-Reply-To: <200804041623.44595.jnareb@gmail.com>

On Fri, Apr 04, 2008 at 03:23:42PM +0100, Jakub Narebski wrote:

Show 12 quoted lines

> When asked for history of a file with no $hash ('h') parameter set,
> and which file is not present in current branch ("HEAD" or given by
> $hash_hase ('hb') parameter), but is present deeper in the full
> history of a branch, gitweb would spew multiple of "Use of
> uninitialized value" warnings, and some links would be missing.
> This commit fixes this bug.
> 
> This bug occurs in the rare cases when "git log -- <path>" is empty
> and "git log --full-history -- <path>" is not.  Gitweb tried to get
> file type (it means if it is 'tree' or 'blob' or even 'commit', as
> 'history' view is for single path which can be any of given types)
> from the commit we start searching from, and not among found commits.

Do you know whether this fixes http://bugs.debian.org/469083 too? I took a short look back then to fix it, but didn't manage it in a reasonable amount of time.

Thanks, Gerrit.