Re: [PATCH] tcl/tk8.5: fix changing colors through Edit->Preferences

From: Gerrit Pape <pape@smarden.org>
Date: Apr 5, 2008, 16:38 UTC
Message-ID: <20080405163842.29563.qmail@4e504c5c8f9cc2.315fe32.mid.smarden.org>
In-Reply-To: <20080326184526.2240.qmail@b31b9595cabb35.315fe32.mid.smarden.org>

On Wed, Mar 26, 2008 at 06:45:26PM +0000, Gerrit Pape wrote:

Show 19 quoted lines

> With tcl/tk8.5 the lset command seems to behave differently.  When
> changing the background color through Edit->Preferences, the changes
> are applied, but new dialogs, such as View->New view... barf with
> 
>  Error: unknown color name "{#ffffff}"
> 
> Additionally when closing gitk, and starting it up again, a bad value
> has been saved to ~/.gitk, preventing gitk from running properly; it
> fails with
> 
>  Error in startup script: unknown color name "{#ffffff}"
>  ...
> 
> This commit changes the color dialogs to not handle variables containing
> just a single color value as tcl lists, which fixes the issue.  Tested
> with tcl/tk8.4 and 8.5.
> 
> Dmitry Potapov reported this problem through
>  http://bugs.debian.org/472615

Hi, any comments on this patch? I can reproduce the problem on Debian with tcl/tk 8.5.1 and git 1.5.5.rc3.

Thanks, Gerrit.