git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/4] add pre-auto-gc hook for git-gc --auto (try2)

From
Miklos Vajna <vmiklos@frugalware.org>
Date
Apr 2, 2008, 19:02 UTC
Message-ID
<20080402190240.GV3264@genesis.frugalware.org>
In-Reply-To
<7vwsngaoqg.fsf@gitster.siamese.dyndns.org>
On Tue, Apr 01, 2008 at 09:02:15PM -0700, Junio C Hamano <gitster@pobox.com> wrote:
Show 6 quoted lines
> > So may I put it back? :)
> 
> I agree that it makes sense to send the output to standard error for
> consistency.  Many existing hooks called from scripted versions of tools
> seem to contaminate the standard output, though.  That would be a good
> post 1.5.5 clean-up, perhaps.
Ok, I will put it back.
> > Also, is the other parts of the series looks correct?
> 
> I do not think we would want empty templates/hooks--pre-gc-auto file.

I did it this way as we have such an empty post-commit hook as well, so I added it for consistency. Though it's true that for example post-applypatch doesn't have such an empty hook under templates either.

What is your opinion here?
Possibilities I see:
1) Just don't add such an empty template for pre-auto-gc.
2) Remove post-commit as well.
3) Add missing empty templates, like post-applypatch (maybe there are
more, I haven't did a complete research).

I've did the rest of the modifications locally as you suggested just I don't want to spam the list with the series before the empty templates question is not clear to me :)

Thanks
Previous: Junio C HamanoNext: Junio C Hamano
Message 6 of 21 in “Re: [PATCH 1/4] git-gc --auto: add pre-auto-gc hook”
  1. Junio C HamanoApr 1, 2008
  2. 0/4 add pre-auto-gc hook for git-gc --auto (try2)Miklos Vajna, Apr 1, 2008
  3. Junio C HamanoApr 1, 2008
  4. Miklos VajnaApr 2, 2008
  5. Junio C HamanoApr 2, 2008
  6. Miklos VajnaApr 2, 2008
  7. Junio C HamanoApr 2, 2008
  8. 0/3 add pre-auto-gc hook for git-gc --auto (try3)Miklos Vajna, Apr 2, 2008
  9. 1/3 git-gc --auto: add pre-auto-gc hookMiklos Vajna, Apr 2, 2008
  10. 2/3 Documentation/hooks: add pre-auto-gc hookMiklos Vajna, Apr 2, 2008
  11. 3/3 contrib/hooks: add an example pre-auto-gc hookMiklos Vajna, Apr 2, 2008
  12. Junio C HamanoApr 2, 2008
  13. 3/3 contrib/hooks: add an example pre-auto-gc hookMiklos Vajna, Apr 2, 2008
  14. Junio C HamanoApr 2, 2008
  15. Miklos VajnaApr 2, 2008
  16. tests for pre-auto-gc hook (WAS: Re: [PATCH 3/3] contrib/hooks: add an example pre-auto-gc hook)Miklos Vajna, Apr 3, 2008
  17. Johannes SixtApr 4, 2008
  18. 1/4 git-gc --auto: add pre-auto-gc hookMiklos Vajna, Apr 1, 2008
  19. 2/4 Documentation/hooks: add pre-auto-gc hookMiklos Vajna, Apr 1, 2008
  20. 3/4 templates: add an example pre-auto-gc hookMiklos Vajna, Apr 1, 2008
  21. 4/4 contrib/hooks: add an example pre-auto-gc hookMiklos Vajna, Apr 1, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.