[PATCH] Describe the bug about handling non-Ascii filenames in 'git add -i'
- From
- Teemu Likonen <tlikonen@iki.fi>
- Date
- Apr 2, 2008, 17:06 UTC
- Message-ID
- <20080402170646.GA12711@mithlond.arda.local>
- In-Reply-To
- <7v63v1ccmb.fsf@gitster.siamese.dyndns.org>
The command 'git add -i' (i.e. the interactive mode) can't handle files which have non-Ascii characters in their name unless the option core.quotepath is set to false. This patch adds a description of the bug to the git-add.txt manual. ---
Junio C Hamano kirjoitti (1.4.2008 klo 17.41):
Show 24 quoted lines
> Jakub Narebski <jnareb@gmail.com> writes: > > > git-config(1): > > > > core.quotepath:: > > The commands that output paths (e.g. `ls-files`, > > `diff`), when not given the `-z` option, will quote > > "unusual" characters in the pathname by enclosing the > > pathname in a double-quote pair and with backslashes the > > same way strings in C source code are quoted. If this > > variable is set to false, the bytes higher than 0x80 are > > not quoted but output as verbatim. Note that double > > quote, backslash and control characters are always > > quoted without `-z` regardless of the setting of this > > variable. > > Yes, but I do not think "add -i" unwraps the path quoting. I think it > should, but I do not think I bothered to. Because it is trivial to do > by any aspiring git hacker wannabes, I left it as an exercise to > readers when I did the "interactive" as a quick-and-dirty hack (aka > "demonstration"). > > Somehow nobody found an itch to improve it until now, but it seems > that we found a volunteer with the itch ;-)
Unfortunately we found a non-programmer :) My itch (both of them) disappeared pretty much at the moment I set core.quotepath to false (thanks Jakub). But this patch is the kind of contribution I can do at the present moment.
Documentation/git-add.txt | 7 +++++++ 1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/Documentation/git-add.txt b/Documentation/git-add.txt index c751a17..f085b15 100644 --- a/Documentation/git-add.txt +++ b/Documentation/git-add.txt @@ -226,6 +226,13 @@ diff:: This lets you review what will be committed (i.e. between HEAD and index). +Bugs +---- +Files with non-Ascii characters in their name don't work in the interactive +mode (see above) unless option 'core.quotepath' is set to false. Setting +'core.quotepath' to false may be a good idea anyway if you need to handle +non-Ascii filenames. See linkgit:git-config[1] for more information about this +option. See Also --------
-- 1.5.5.rc2.15.g4db6