Re: [PATCH] git-gui: Add shortcut keys for Show More/Less Context
- From
Shawn O. Pearce <spearce@spearce.org>
- Date
- Mar 29, 2008, 05:44 UTC
- Message-ID
- <20080329054440.GP4759@spearce.org>
- In-Reply-To
- <57518fd10803280622v3a5f6ae8lcfd35270ab9ede1e@mail.gmail.com>
Jonathan del Strother <maillist@steelskies.com> wrote:
Show 7 quoted lines
> Bound to Ctrl/Cmd (depending on your platform) + left & right square brackets. > --- > > I'm not at all familiar with Tcl, so I apologise in advance for any > wrongness. I frequently find myself repeatedly right-clicking->Show > Less Context in order to stage a specific hunk, seems like a shortcut > for this would be useful. Thoughts?
Looks good to me. FWIW your patch was sent with a content-type of format=flawed, so I had to manually unwrap the diff hunk headers to get it to apply.
I think we should also put these into the menu bar too, like say the commit menu, so users can see what the keyboard action is to invoke the increase/decrease.
Also, missing a Signed-off-by line. If you can contribute this change according to the statement outlined in Documentation/SubmittingPatches please send me one.
-- Shawn.