[PATCH] imap-send: properly error out if imap.host is not set in config
- From
Gerrit Pape <pape@smarden.org>
- Date
- Mar 26, 2008, 18:05 UTC
- Message-ID
- <20080326180517.23968.qmail@945917b39a7083.315fe32.mid.smarden.org>
If no imap host is specified in the git config, git imap-send used to try to lookup a null pointer through gethostbyname(), causing a segfault. Since setting the imap.host variable is mandatory, imap-send now properly fails with an explanatory error message.
The problem has been reported by picca through http://bugs.debian.org/472632
Signed-off-by: Gerrit Pape <pape@smarden.org> --- imap-send.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/imap-send.c b/imap-send.c index 10cce15..04afbc4 100644 --- a/imap-send.c +++ b/imap-send.c @@ -1302,6 +1302,10 @@ main(int argc, char **argv) fprintf( stderr, "no imap store specified\n" ); return 1; } + if (!server.host) { + fprintf( stderr, "no imap host specified\n" ); + return 1; + } /* read the messages */ if (!read_message( stdin, &all_msgs )) {
-- 1.5.4.4