Re: [PATCH 2/2] send-email: rfc2047-quote subject lines with non-ascii characters

From: Jeff King <peff@peff.net>
Date: Mar 26, 2008, 09:33 UTC
Message-ID: <20080326093310.GA937@coredump.intra.peff.net>
In-Reply-To: <20080326092303.GA17835@mithlond.arda.local>

On Wed, Mar 26, 2008 at 11:23:03AM +0200, Teemu Likonen wrote:

Show 5 quoted lines

> Hmm, do you send the 0000-cover-letter.patch with 'git send-email'? It
> seems that this cover letter don't get MIME headers when sent that way.
> Sending through 'mutt -H' it works fine but then the Message-Id needs to
> be copy-pasted manually to send-mail for the rest of the series (to have
> them appear as replies, that is). No problem with that.

No, I have format-patch do the threading. So something like:

  git format-patch --cover-letter --thread --stdout upstream >mbox
  mutt -f mbox

and then in mutt I bind a key to <resend-message>. For each message, I do the 'resend', set the recipient headers, look it over one last time, and then send. The most annoying part is entering the recipients; usually it isn't too bad because I have short aliases for Junio and the list, but I had to, e.g., cut and paste your address twice for the other series.

Probably munging the 'to:' and 'cc:' before running mutt would make the most sense, but I haven't gotten around to it yet.

> I mostly use (and promote) UTF-8 and now that I begin to understand how
> send-email works I can live with the current behaviour just fine. Don't
> take my feedback as complaining. :)

OK, I am inclined to leave the patches as-is, then, and wait for somebody to complain about their pet encoding. My reasoning is that:

  - in most cases throughout git, we assume things are happening in
    utf-8, so I don't think it will come as a great surprise
  - I think doing it right might be more complex than just send-mail; I
    am thinking there might need to be a "stuff the user inputs is in
    encoding X" config option. And I don't want to do the work. :)

> Thanks for your work on this. Really.

No problem at all. Thank you for helping make git better with bug reports!

-Peff