git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] [RFC] add Message-ID field to log on git-am operation

From
AGAnton Gladkov <agladkov@parallels.com>
Date
Mar 24, 2008, 06:43 UTC
Message-ID
<20080324064327.GE22468@atn.sw.ru>
In-Reply-To
<7v4pax70lz.fsf@gitster.siamese.dyndns.org>
On Sun, Mar 23, 2008 at 11:32:08AM -0700, Junio C Hamano wrote:
Show 17 quoted lines
> Anton Gladkov <agladkov@parallels.com> writes:
> > ...
> > applypatch-msg hook executed on message applying, after that there could be
> > useful to test applied patch, so it is not the place for notification sending.
> 
> And nobody suggested to send anything from the hook.
> 
> As I understood from your e-mail without proposed commit log message, your
> assumed workflow was:
> 
> 	receive mail
>         "git am" it
> 	test rewrite amend whatever you want to convince yourself that
>          the received patch was Ok
>         push the result out
>         pushed-into repository has a hook to send notification,
>          by picking up the Message-ID from the commit object
That is it.
Show 7 quoted lines
> 
> The only thing you need was that the message-id information is available
> somewhere in the commit object.  I objected to your patch that puts it in
> the commit object header and suggested it be placed in the commit log
> message.  You can implement such custom commit munging to add an extra
> Message-ID: line inside the hook.  You do not have to send out e-mail nor
> anything from it.
I've got your idea! Thank you :)
-- 
Best regards,
		anton
mailto:agladkov@sw.ru
Previous: Junio C Hamano
Message 5 of 5 in “[RFC] add Message-ID field to log on git-am operation”
  1. [RFC] add Message-ID field to log on git-am operationAnton Gladkov, Mar 21, 2008
  2. Junio C HamanoMar 22, 2008
  3. Anton GladkovMar 23, 2008
  4. Junio C HamanoMar 23, 2008
  5. Anton GladkovMar 24, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.