Re: [PATCH 1/2] web--browse: use custom commands defined at config time

From: Christian Couder <chriscool@tuxfamily.org>
Date: Mar 18, 2008, 04:56 UTC
Message-ID: <200803180556.51930.chriscool@tuxfamily.org>
In-Reply-To: <200803151300.m2FD0XWh003243@localhost.localdomain>

Le samedi 15 mars 2008, Xavier Maillard a écrit :

>    This patch adds a git config variable "browser.<tool>.cmd" which
>    allows a more flexible browser choice.
>
> Well done ! Now we need it in help.c too :)

I started by "man.<tool>.path" (patches should follow soon), and I will work on "man.<tool>.cmd" really soon now.

>    Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
>
> Tested-by: Xavier Maillard <xma@gnu.org>

Thanks again for your tests. They are very much appreciated.

> Please update the header file as well (copyright header, it is
> year 2008 here :)).

Is it so important ? Some files like "help.c" don't even have copyright notice. Isn't it ok as long as they come with the license file (COPYING) ?

Thanks, Christian.