Re: [PATCH 00/16] solaris portability patches

From: Jeff King <peff@peff.net>
Date: Mar 13, 2008, 13:15 UTC
Message-ID: <20080313131549.GK19485@coredump.intra.peff.net>
In-Reply-To: <7v4pbbys4a.fsf@gitster.siamese.dyndns.org>

On Thu, Mar 13, 2008 at 12:56:21AM -0700, Junio C Hamano wrote:

> Whew, a huge series.

Yes, sorry to spam you when we are supposed to be freezing. I saw that Whit was still trying to run the testsuite, and I thought "I'll just take a quick peek at getting this to run." 16 patches and a half day's missing day-job work later, you see the result. :)

Show 18 quoted lines

> I've queued the following for now.
> 
>     [PATCH 01/16] tr portability fixes
>     [PATCH 02/16] t0050: perl portability fix
>     [PATCH 03/16] more tr portability test script fixes
>     [PATCH 04/16] grep portability fix: don't use "-e" or "-q"
>     [PATCH 05/16] remove use of "tail -n 1" and "tail -1"
>     [PATCH 06/16] add test_cmp function for test scripts
>     [PATCH 07/16] t4020: don't use grep -a
>     [PATCH 09/16] t6000lib: tr portability fix
>     [PATCH 10/16] add NO_EXTERNAL_GREP build option
>     [PATCH 13/16] filter-branch: don't use xargs -0
>     [PATCH 14/16] filter-branch: use $SHELL_PATH instead of 'sh'
>     [PATCH 15/16] t9112: add missing #!/bin/sh header
>     [PATCH 16/16] t7505: use SHELL_PATH in hook
> 
> but being this close to -rc0 I do not really enjoy too disruptive
> patches.

A lot of these are "help the test scripts run" and not "help git run." However, the "help git run" ones are probably nice for Solaris people. OTOH, most of them probably have xpg4 in their PATH, which helps a lot (although things like 14/16 mean filter-branch is totally broken for anyone on Solaris).

I think the ones you dropped make sense. I'll put "try to clean up builtin-config" on my post-1.5.5 todo. In the meantime, I think it is only hurting git-submodule users on Solaris who don't have xpg4 in their PATH.

The t4200 thing is potentially showing a bug in builtin-rerere, so I think following up on that is worthwhile. I'll see if I can construct a multi-file test case to trigger it.

-Peff