Re: [PATCH] Don't try and percent-escape existing percent escapes in git-svn URIs

From: Eric Wong <normalperson@yhbt.net>
Date: Mar 10, 2008, 01:15 UTC
Message-ID: <20080310011523.GB17484@mayonaise>
In-Reply-To: <0FE6BDE6-961E-4671-B9EC-EFA25389DF54@sb.org>

Kevin Ballard <kevin@sb.org> wrote:

Show 14 quoted lines

> On Mar 9, 2008, at 5:12 AM, Eric Wong wrote:
> 
> >Kevin Ballard <kevin@sb.org> wrote:
> >>git-svn: project names are percent-escaped ever since f5530b.
> >>Unfortunately this breaks the scenario where the user hands git-svn
> >>an already-escaped URI. Fix the regexp to skip over what looks like
> >>existing percent escapes, and test this scenario.
> >
> >What happens when something that _looks_ like a percent escape is
> >actually a part of the URL and not really an escape?
> 
> Have you ever seen a URL like that? I haven't. However, what is fairly  
> common is for URLs to contain spaces, and such URLs are always stored  
> already-escaped.

No, but I wouldn't be surprised if they existed (as people are already crazy enough to put spaces in URLs).

Show 13 quoted lines

> The standard situation that triggers this issue is pulling a URL from  
> `svn info`. Such a URL is already escaped, which means you can't feed  
> it into `git svn clone` directly, you have to de-escape it first. This  
> is a problem. Here's an example:
> 
> http://macromates.com/svn/Bundles/trunk/Bundles/Ruby%20on%20Rails.tmbundle
> 
> I tried cloning that and it failed, because it turned that into
> 
> http://macromates.com/svn/Bundles/trunk/Bundles/Ruby%2520on%2520Rails.tmbundle
> 
> However, my friend who was still on v1.5.3.7 cloned that no problem,  
> since that was before the escaping code.

OK, I'll accept this. If they really want to represent '%', they should use "%25". But this should only be done for http/https URLs as svn(+ssh):// and file:// repositories aren't subject to the same rules http/https are.

-- 
Eric Wong