Re: [RFC/PATCH] gitweb: Use list form of 'open "-|"' pipeline

From: Charles Bailey <charles@hashpling.org>
Date: Mar 8, 2008, 17:51 UTC
Message-ID: <20080308175106.GA13855@hashpling.org>
In-Reply-To: <20080308165245.15343.62914.stgit@localhost.localdomain>

On Sat, Mar 08, 2008 at 05:57:20PM +0100, Jakub Narebski wrote:

Show 9 quoted lines

> Add output_pipeline subroutine, which allows to use list form of
> pipeline; instead of
>   open my $fh, "-|", "cmd_1 option | cmd_2 argument"
> we can now write
>   my $fh = output_pipeline(['cmd_1', 'option'], ['cmd_2', 'argument']);
> which allows to avoid troubles with shell quoting, and avoid spawning
> shell.  Code is based on snippet http://www.perlmonks.org/?node_id=246397
> simplified a bit.
>

I'm not a perl open expert, and I don't know if gitweb has other issues on windows anyway, but the list time I experimented with it neither the open( FHAND, "-|" ) trick, not the list form of open in combination with the "-|" mode worked at all on windows.

Charles.