Re: [PATCH v2] gitk: Add horizontal scrollbar to the diff view
- From
- Pekka Kaitaniemi <kaitanie@cc.helsinki.fi>
- Date
- Mar 7, 2008, 12:16 UTC
- Message-ID
- <20080307121619.GA1768@localdomain>
- In-Reply-To
- <18384.30851.318641.612252@cargo.ozlabs.ibm.com>
On Fri, Mar 07, 2008 at 10:04:35AM +1100, Paul Mackerras wrote:
Show 6 quoted lines
> Pekka Kaitaniemi writes: > > > - -yscrollcommand scrolltext -wrap none > > + -yscrollcommand scrolltext -wrap none \ > > Why this whitespace change?
For no good reason at all... Fixed. The real change was the \ at the end of the line.
Show 6 quoted lines
> > + scrollbar .bleft.sbhorizontal -command "$ctext xview" -orient h \ > > + -width 10 > > Are you using Tk 8.4 or 8.5? With Tk 8.5 the scrollbars are thinner > and I wonder whether specifying a width of 10 will actually make it > fatter than it would be otherwise.
I was using Tk 8.4 to make the patch. Today I installed 8.5. On 8.5 it seems that the horizontal scroll bar is as wide as the default one, or maybe slightly narrower so it looks quite OK. At least it behaves this way on Linux. I can't really test how well it works on Mac and Windows since I don't use them.
So Tk 8.5 actually has more reasonably sized scrollbars than 8.4. Maybe the hardcoded width setting should be dropped? This would probably make the patch more "cross plattform" because Windows and Mac versions of Tk may have different "themes" and scrollbar widths than the Linux version. On those plattforms the width of 10 might be fatter than the default.
Pekka