Re: [PATCH] git-clean: correct printing relative path

From: Pierre Habouzit <madcoder@debian.org>
Date: Mar 5, 2008, 15:59 UTC
Message-ID: <20080305155943.GB15843@artemis.madism.org>
In-Reply-To: <20080305155359.GA15843@artemis.madism.org>

On mer, mar 05, 2008 at 03:53:59 +0000, Pierre Habouzit wrote:

Show 12 quoted lines

> On Wed, Mar 05, 2008 at 02:17:20PM +0000, Dmitry Potapov wrote:
> > When the given path contains '..' then git-clean incorrectly printed names
> > of files. This patch changes cmd_clean to use quote_path() from wt-status.
> > Also, "failed to remove ..." message used absolutely path, but not it is
> > corrected to use relative path.
> > 
> > Signed-off-by: Dmitry Potapov <dpotapov@gmail.com>
> > ---
> > I resend this patch, because it got filtered by vger.kernel.org
> > when I used git-send-email from 1.5.4.
> 
>   It didn't FWIW.

  And as far as it goes for your patch, it misses a #include
"wt-status.h" and for me it gives:

    git clean ..
    Removing ../
    Removing ../git-clean.patch
    Removing ../stFdw8KY

For a tree that had those unclean entries.
    ../git-clean.patch
    ../stFdw8KY

  Removing ../ is clearly wrong both times: it didn't really did that
(my current dir was the 't/' dir in the git repository for that) and I
didn't specified 'git clean -d'.

-- 
·O·  Pierre Habouzit
··O                                                madcoder@debian.org
OOO                                                http://www.madism.org