Re: [PATCH] Fix random crashes in http_cleanup()

From: Gerrit Pape <pape@smarden.org>
Date: Mar 3, 2008, 10:01 UTC
Message-ID: <20080303100141.15600.qmail@e81d07a86798f7.315fe32.mid.smarden.org>
In-Reply-To: <1204489713-8696-1-git-send-email-mh@glandium.org>

On Sun, Mar 02, 2008 at 09:28:33PM +0100, Mike Hommey wrote:

Show 5 quoted lines

> For some reason, http_cleanup was running all active slots, which could
> lead in situations where a freed slot would be accessed in
> fill_active_slots. OTOH, we are cleaning up, which means the caller
> doesn't care about pending requests. Just forget about them instead
> or running them.

Hi, I can confirm that this fixes the segfault we managed to reproduce, but didn't look deeper into the changes.

There's a warning when compiling http.c, trivial to fix:

      CC http.o
  http.c: In function ‘http_cleanup’:
  http.c:288: warning: unused variable ‘wait_url’

Thanks!, Gerrit.