Re: [PATCH 1/2] Simple rename of top-most patch
- From
Karl Hasselström <kha@treskal.com>
- Date
- Feb 22, 2008, 07:44 UTC
- Message-ID
- <20080222074455.GC6630@diana.vm.bytemark.co.uk>
- In-Reply-To
- <200802212242.51866.onno@gmx.net>
On 2008-02-21 22:42:51 +0100, Onno Kortmann wrote:
Show 6 quoted lines
> + if len(args) == 2: > + old, new=args > + elif len(args) == 1: > + if not crt: > + raise CmdException, "No applied top patch to rename exists." > + old, [new]=crt, args
I think the style throughout StGit is to have spaces arond operators. No biggie, though -- I'll fix it up.
> + else: parser.error('incorrect number of arguments')It looks strange without a line break here, especially since there are line breaks in the if and elif branches. I'll fix this too if you don't mind.
--
Karl Hasselström, kha@treskal.com
www.treskal.com/kalle