Re: Solaris test failure -- FAIL 61: invalid bool (set)

From: Jeff King <peff@peff.net>
Date: Feb 20, 2008, 05:04 UTC
Message-ID: <20080220050420.GA16745@coredump.intra.peff.net>
In-Reply-To: <8ec76080802191611s3348beb1icd0b24db8b0a9556@mail.gmail.com>

On Tue, Feb 19, 2008 at 07:11:01PM -0500, Whit Armstrong wrote:

> That certainly fixes t1300-repo-config.sh.
> 
> I must be seeing the same failures as you ( in t3404-rebase-interactive.sh ).

I actually was seeing errors later in t1300, but they were fixed by putting GNU coreutils at the front of my path (btw, we had discussed previously using "diff -u" to compare actual and expected output in many tests -- Solaris diff doesn't understand "-u").

I see the errors in t3404. They are caused by the Solaris /bin/sh not understanding $() syntax. We create a "fake-editor" script to simulate the editor during interactive rebase, and it is hard-coded to /bin/sh.

So we should probably do something like:

diff --git a/t/t3404-rebase-interactive.sh b/t/t3404-rebase-interactive.sh
index e5ed745..62e65d7 100755
--- a/t/t3404-rebase-interactive.sh
+++ b/t/t3404-rebase-interactive.sh
@@ -61,8 +61,8 @@ test_expect_success 'setup' '
 	git tag I
 '
 
-cat > fake-editor.sh <<\EOF
-#!/bin/sh
+echo "#!$SHELL" >fake-editor
+cat >> fake-editor.sh <<\EOF
 case "$1" in
 */COMMIT_EDITMSG)
 	test -z "$FAKE_COMMIT_MESSAGE" || echo "$FAKE_COMMIT_MESSAGE" > "$1"

There are probably more instances of this problem, but I haven't
checked. I had high hopes of running the testsuite to completion
tonight, but I am getting stuck now in t3900.

-Peff