[PATCH 1/3] push: indicate partialness of error message
- From
Jeff King <peff@peff.net>
- Date
- Feb 19, 2008, 16:25 UTC
- Message-ID
- <20080219162501.GA30451@sigill.intra.peff.net>
The existing message indicates that an error occured during push, but it is unclear whether _any_ refs were actually pushed (even though the status table above shows which were pushed successfully and which were not, the message "failed to push" implies a total failure). By indicating that "some refs" failed, we hopefully indicate to the user that the table above contains the details.
We could also put in an explicit "see above for details" message, but it seemed to clutter the output quite a bit (both on a line of its own, or at the end of the error line, which inevitably wraps).
This could also be made more fancy if the transport mechanism passed back more details on how many refs succeeded and failed:
error: failed to push %d out of %d refs to '%s'
Signed-off-by: Jeff King <peff@peff.net> --- This patch series is meant to address some user issues encountered in the recent thread "git push [rejected] question". It's entirely message and documentation updates.
builtin-push.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/builtin-push.c b/builtin-push.c index c8cb63e..9f727c0 100644 --- a/builtin-push.c +++ b/builtin-push.c @@ -90,7 +90,7 @@ static int do_push(const char *repo, int flags) if (!err) continue; - error("failed to push to '%s'", remote->url[i]); + error("failed to push some refs to '%s'", remote->url[i]); errs++; } return !!errs;
-- 1.5.4.1.143.ge7e51-dirty