git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: another git rebase -i problem

From
Uwe Kleine-König <uwe.kleine-koenig@digi.com>
Date
Feb 14, 2008, 13:02 UTC
Message-ID
<20080214130228.GB28472@digi.com>
In-Reply-To
<alpine.LSU.1.00.0802141232070.30505@racer.site>
Johannes Schindelin wrote:
Show 21 quoted lines
> Hi,
> 
> On Thu, 14 Feb 2008, Uwe Kleine-König wrote:
> 
> > After applying the patch below, the test fails. [describes a case where 
> > all patches were applied upstream already]
> 
> This is by design.  If no patches are to be applied, there is nothing you 
> can do interactively.  And git rebase -i should tell you as much:
> 
> 	Nothing to do
> 
> Maybe it should say
> 
> 	There is nothing you can rebase interactively
> 
> But I don't like that.
>
> Alternatively, git rebase -i could reset --hard to upstream, but I don't 
> like that either: if I rebase -i, it is because I want to reorder/arrange 
> patches.  If there is no patch to be rearranged, I did something wrong.
Ah, OK this disqualifies my test case, but the problem is real:
diff --git a/t/t3404-rebase-interactive.sh b/t/t3404-rebase-interactive.sh
index e5ed745..f0499e6 100755
--- a/t/t3404-rebase-interactive.sh
+++ b/t/t3404-rebase-interactive.sh
@@ -362,4 +362,11 @@ test_expect_success 'rebase with a file named HEAD in worktree' '
 
 '
 
+test_expect_success 'rebase patch already merged' '
+
+	git checkout -b branch4 twerp &&
+	FAKE_LINES="1 2 4 3" git rebase -i branch3
+
+'
+
 test_done

Best regards
Uwe
-- 
Uwe Kleine-König, Software Engineer
Digi International GmbH Branch Breisach, Küferstrasse 8, 79206 Breisach, Germany
Tax: 315/5781/0242 / VAT: DE153662976 / Reg. Amtsgericht Dortmund HRB 13962
Previous: Johannes SchindelinNext: Johannes Schindelin
Message 3 of 6 in “another git rebase -i problem”
  1. Uwe Kleine-KönigFeb 14, 2008
  2. Johannes SchindelinFeb 14, 2008
  3. Uwe Kleine-KönigFeb 14, 2008
  4. Johannes SchindelinFeb 14, 2008
  5. Uwe Kleine-KönigFeb 15, 2008
  6. Uwe Kleine-KönigFeb 15, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.