[PATCH 3/5] Include the fast-import marks table in crash reports
- From
Shawn O. Pearce <spearce@spearce.org>
- Date
- Feb 14, 2008, 06:34 UTC
- Message-ID
- <20080214063440.GC30678@spearce.org>
If fast-import was not run with --export-marks but we are crashing the frontend application developer may still benefit from having that information available to them. We now include the marks table as part of the crash report if --export-marks was not supplied on the command line.
Signed-off-by: Shawn O. Pearce <spearce@spearce.org> --- fast-import.c | 10 ++++++++++ 1 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/fast-import.c b/fast-import.c index 8ef607f..117f38c 100644 --- a/fast-import.c +++ b/fast-import.c @@ -372,6 +372,8 @@ static void write_branch_report(FILE *rpt, struct branch *b) fputc('\n', rpt); } +static void dump_marks_helper(FILE *, uintmax_t, struct mark_set *); + static void write_crash_report(const char *err) { char *loc = git_path("fast_import_crash_%d", getpid()); @@ -444,6 +446,14 @@ static void write_crash_report(const char *err) } fputc('\n', rpt); + fputs("Marks\n", rpt); + fputs("-----\n", rpt); + if (mark_file) + fprintf(rpt, " exported to %s\n", mark_file); + else + dump_marks_helper(rpt, 0, marks); + + fputc('\n', rpt); fputs("-------------------\n", rpt); fputs("END OF CRASH REPORT\n", rpt); fclose(rpt);
-- 1.5.4.1.1309.g833c2