Re: [RFC Patch] Preventing corrupt objects from entering the repository
- From
Shawn O. Pearce <spearce@spearce.org>
- Date
- Feb 14, 2008, 06:16 UTC
- Message-ID
- <20080214061651.GH24004@spearce.org>
- In-Reply-To
- <alpine.LSU.1.00.0802131200410.30505@racer.site>
Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
> On Wed, 13 Feb 2008, Martin Koegler wrote: > > > This would mean, that we must make git-rev-list and git-pack-objects not > > segfault on incorrect links between objects.
My proposal suggested that malformed objects not be allowed into the repository, so rev-list wouldn't see them in the first place.
> We should do that anyway. It may error out, but segfaulting is no option. > > So if you have a test case, please make it public so we can fix the > breakage.
But Dscho has a really good point here. rev-list should be failing with a proper exit code, not SIGSEGV. :)
-- Shawn.