Re: [PATCH] git-gui: support Git Gui.app under OS X 10.5

From: Shawn O. Pearce <spearce@spearce.org>
Date: Feb 12, 2008, 07:33 UTC
Message-ID: <20080212073306.GA24004@spearce.org>
In-Reply-To: <m2d4r30yjf.fsf@userprimary.net>

Seth Falcon <seth@userprimary.net> wrote:

Show 10 quoted lines

> jaysoffian@gmail.com writes:
> > The Tk Framework moved its location in 10.5 compared to 10.4
> >
> > Signed-off-by: Jay Soffian <jaysoffian@gmail.com>
> > ---
> > Argh. Third time's a charm? Sorry, forgot to add my change before
> > amending and resending.
> 
> I applied this and things work much better, thanks!
> Tested-by: Seth Falcon <seth@userprimary.net>

Thanks guys.  This is now in maint and master.  Its going to
be part of git-gui 0.9.3, whenever that happens.

> One thing.  When I quit git gui I see the following on the terminal:
> 
> TkMacOSXDoHLEvent failed : cppe 1                   ,kHighLevelEvent  61657674 0000 tvea,-1708

Yea, I see some random errors from git-gui when I use an option menu. I think there's something buggy with Tk on Aqua. Maybe we should report these to the Tk Aqua folks, especially if we could distill the issue down to a really short Tk script.

-- 
Shawn.