Re: Add "--show-all" revision walker flag for debugging

From: Jakub Narebski <jnareb@gmail.com>
Date: Feb 11, 2008, 01:24 UTC
Message-ID: <200802110224.48790.jnareb@gmail.com>
In-Reply-To: <alpine.LFD.1.00.0802101507100.2896@woody.linux-foundation.org>

Linus Torvalds wrote:

Show 9 quoted lines

> On Sun, 10 Feb 2008, Jakub Narebski wrote:
> > 
> > Well, we could always add it as a local (per repository) "cache".
> > With only generation numbers we could use pack-index-like format
> > to store a mapping "commit sha-1 => generation number", just like
> > now pack index stores mapping "object sha-1 => offset in pack".
> 
> Yes, and even embedding this in the pack-file (or perhaps, the index, as a 
> new index extension) is probably a good idea.

Errr... index is per workarea (per checkout), and this information is per repository, so IMHO storing this info in an index (dircache) is a layering violation. Unless you were talking about pack-file-index.

I think that separate file is better idea, this way we can update generation info lazily: when we went to the root or project whose all parents have generatrion number, then we save gen numbers to such "cache" file. If we had to calculate it (even accidentally), save it.

Show 9 quoted lines

> > If we want to store also roots, we could either map 
> > "commit sha-1 => generation number, roots set offset / id" (constant
> > length value)[*1*], or have gen-*.gen file with generation numbers
> > and roots, and gen-*.idx as index to that file.
> 
> The thing is, the roots are almost never actually interesting. Very seldom 
> do you have any issue with different commits having different roots. So I 
> really don't think it's worth it, considering that it's also much more 
> complicated than just adding a sequence number to each commit.

Weren't the cases of multiple roots that were difficult? Storing roots would help with 'hard' (if seldom happening) cases then.

-- 
Jakub Narebski
Poland