git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Alternative approach to the git config NULL value checking patches..

From
Pierre Habouzit <madcoder@debian.org>
Date
Feb 10, 2008, 23:29 UTC
Message-ID
<20080210232920.GH5129@artemis.madism.org>
In-Reply-To
<7v7ihce8ex.fsf@gitster.siamese.dyndns.org>
On Sun, Feb 10, 2008 at 10:47:02PM +0000, Junio C Hamano wrote:
Show 26 quoted lines
> Junio C Hamano <gitster@pobox.com> writes:
> 
> > But as you seem to imply, it might make sense to equate
> >
> > 	[some-random-section]
> >         	some-random-variable
> >
> > to
> >
> > 	[some-random-section]
> >         	some-random-variable = ""
> >
> > for variables that cannot possibly have any meaningful "bool"
> > semantics.  This third class of variables is a possible benefit
> > your patch brings in.  The code can be lax for these variables.
> >
> > However, it would make things inconsistent ("this variable is
> > bool and the above two forms mean completely opposite things,
> > while that variable is not bool and they mean the same thing").
> > I am just having a hard time convincing myself that this little
> > detail does not matter.
> 
> Having said all that, it might be an option to change your patch
> slightly to say:
> 
> 	const char config_true[] = "true";

I was about to suggest the same, and testing against "config_true" just becomes an optimization, but isn't required. Seems an appropriate hack to me.

-- 
·O·  Pierre Habouzit
··O                                                madcoder@debian.org
OOO                                                http://www.madism.org
Previous: Junio C HamanoNext: Linus Torvalds
Message 6 of 13 in “Alternative approach to the git config NULL value checking patches..”
  1. Linus TorvaldsFeb 10, 2008
  2. Junio C HamanoFeb 10, 2008
  3. Linus TorvaldsFeb 10, 2008
  4. Junio C HamanoFeb 10, 2008
  5. Junio C HamanoFeb 10, 2008
  6. Pierre HabouzitFeb 10, 2008
  7. Linus TorvaldsFeb 10, 2008
  8. Linus TorvaldsFeb 10, 2008
  9. Linus TorvaldsFeb 10, 2008
  10. Junio C HamanoFeb 11, 2008
  11. Christian CouderFeb 11, 2008
  12. Junio C HamanoFeb 11, 2008
  13. Daniel BarkalowFeb 11, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.