git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [EGIT PATCH] Comment private modifier to improve performace.

From
Robin Rosenberg <robin.rosenberg@dewire.com>
Date
Feb 3, 2008, 22:14 UTC
Message-ID
<200802032314.34005.robin.rosenberg@dewire.com>
In-Reply-To
<47A61E17.7060303@intelinet.com.br>
söndagen den 3 februari 2008 skrev Roger C. Soares:
Show 7 quoted lines
> With the else warnings patch I'm ok.
> 
> About the discouraged access, I read those warnings as: we are using 
> methods that are not part of the eclipse public API and they can change 
> in the future. Not depending on internal eclipse API will make egit less 
> likely to break with a future eclipse version, which sounds like a good 
> thing to me. So, I would keep those.

The thing with that one is that by default the warning is on, so removing the setting doesn't remvoe the warning unless one disables it at the workspace level. I'll hold it back for the moment anyway and push the "else" and "synthetic" patches. Thanks for your opinions on the subject matter.

-- robin
Previous: Roger C. SoaresNext: Roger C. Soares
Message 5 of 7 in “Comment private modifier to improve performace.”
  1. Comment private modifier to improve performace.Roger C. Soares, Feb 2, 2008
  2. Robin RosenbergFeb 3, 2008
  3. Robin RosenbergFeb 3, 2008
  4. Roger C. SoaresFeb 3, 2008
  5. Robin RosenbergFeb 3, 2008
  6. Roger C. SoaresFeb 3, 2008
  7. Robin RosenbergFeb 3, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.