git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/2] git-svn: Don't call git-repack anymore

From
Karl Hasselström <kha@treskal.com>
Date
Feb 3, 2008, 16:56 UTC
Message-ID
<20080203165612.10816.35458.stgit@yoghurt>
In-Reply-To
<20080203165234.10816.6061.stgit@yoghurt>

In a moment, we'll start calling git-gc --auto instead, since it is a better fit to what we're trying to accomplish.

The command line options are still accepted, but don't have any effect, and we warn the user about that.

Signed-off-by: Karl Hasselström <kha@treskal.com>
---
 git-svn.perl |   14 +++-----------
 1 files changed, 3 insertions(+), 11 deletions(-)
diff --git a/git-svn.perl b/git-svn.perl
index 75e97cc..074068c 100755
--- a/git-svn.perl
+++ b/git-svn.perl
@@ -1247,7 +1247,6 @@ use File::Path qw/mkpath/;
 use File::Copy qw/copy/;
 use IPC::Open3;
 
-my $_repack_nr;
 # properties that we do not log:
 my %SKIP_PROP;
 BEGIN {
@@ -1408,9 +1407,9 @@ sub read_all_remotes {
 }
 
 sub init_vars {
-	$_repack = 1000 unless (defined $_repack && $_repack > 0);
-	$_repack_nr = $_repack;
-	$_repack_flags ||= '-d';
+	if (defined $_repack || defined $_repack_flags) {
+	       warn "Repack options are obsolete; they have no effect.\n";
+	}
 }
 
 sub verify_remotes_sanity {
@@ -2149,13 +2148,6 @@ sub do_git_commit {
 		                   0, $self->svm_uuid);
 	}
 	print " = $commit ($self->{ref_id})\n";
-	if ($_repack && (--$_repack_nr == 0)) {
-		$_repack_nr = $_repack;
-		# repack doesn't use any arguments with spaces in them, does it?
-		print "Running git repack $_repack_flags ...\n";
-		command_noisy('repack', split(/\s+/, $_repack_flags));
-		print "Done repacking\n";
-	}
 	return $commit;
 }
 
Previous: Karl HasselströmNext: Karl Hasselström
Message 2 of 3 in “"git svn" and "git gc --auto"”
  1. 0/2 "git svn" and "git gc --auto"Karl Hasselström, Feb 3, 2008
  2. 1/2 git-svn: Don't call git-repack anymoreKarl Hasselström, Feb 3, 2008
  3. 2/2 Let "git svn" run "git gc --auto" occasionallyKarl Hasselström, Feb 3, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.