Re: [bug] generic issue with git_config handlers

From: Pierre Habouzit <madcoder@debian.org>
Date: Jan 31, 2008, 10:10 UTC
Message-ID: <20080131101037.GG24403@artemis.madism.org>
In-Reply-To: <7v1w7ye48j.fsf@gitster.siamese.dyndns.org>

On Thu, Jan 31, 2008 at 09:25:32AM +0000, Junio C Hamano wrote:

Show 16 quoted lines

> Pierre Habouzit <madcoder@debian.org> writes:
> 
> >   One of my co-workers stumbled upon a misfeature of the git config
> > parser. The following syntax is allowed:
> >
> >     [section]
> > 	 foo
> 
> Yeah, that is how "truth" value of boolean is spelled.
> 
> > [user]
> >     name
> 
> That's very unfortunate.  Whatever is expecting string value
> should check for NULL.  Fix should probably be easy enough for
> any git-hacker-wannabe to tackle ;-)

  I think so too, though my count is something like 40 functions to
investigate (the 40 handlers) and where it recurses into ;) Too much
work for the time I have right now.

-- 
·O·  Pierre Habouzit
··O                                                madcoder@debian.org
OOO                                                http://www.madism.org