Re: [PATCH] config.c: Expand $HOME and tilde character in core.excludesfile
- From
Wayne Davison <wayne@opencoder.net>
- Date
- Jan 28, 2008, 23:52 UTC
- Message-ID
- <20080128235205.GE8669@blorf.net>
- In-Reply-To
- <y7a9aaem.fsf@blue.sea.net>
On Mon, Jan 28, 2008 at 11:49:05PM +0200, Jari Aalto wrote:
> + ret = str_replace(str, "~", home);
This would mangle a name with a tilde in it, e.g. "file.c~", etc.
> + ret = str_replace(str, "$HOME", home);
This would affect similarly named vars, e.g. $HOMER, etc.
> + strcat( ptr, ""); /* Terminate with null string */
Calling strcat() requires a null-terminated string. Instead, assign a '\0' char at the right position.
..wayne..