Re: [PATCH] autoconf: Add test for sys/select.h header file
- From
Robert Schiele <rschiele@gmail.com>
- Date
- Jan 26, 2008, 09:42 UTC
- Message-ID
- <20080126094253.GP30676@schiele.dyndns.org>
- In-Reply-To
- <7v8x2d3xya.fsf@gitster.siamese.dyndns.org>
On Fri, Jan 25, 2008 at 10:25:33PM -0800, Junio C Hamano wrote:
> The issue is not really about "do we have <sys/select.h>?" but > is about "do we need to include <sys/select.h> in order to > obtain declaration of select(2)?" so this is covering only a
This is true. Actually HP-UX 11.23 for instance has sys/select.h but this is not intended to be included to get the select call but this is intended to be included by kernel drivers that implement the interface the kernel needs to _provide_ the select call. In that case the test determines that sys/select.h exists but it does not notice that it is not the header to include. It does not hurt though since including sys/select.h outside of a kernel driver is a no-op and we include sys/time.h which is really needed anyway.
Show 6 quoted lines
> half of the issue. But I guess we will find out if the system > does not offer select(2) whether <sys/select.h> is included or > not, so this is not too bad. > > Will apply. I do not think it would have problems but even if > it does it is small and easy to revert before the final.
At least on the systems I know it does not hurt even when it does not always exactly what it is intended to do.
Robert
-- Robert Schiele Dipl.-Wirtsch.informatiker mailto:rschiele@gmail.com "Quidquid latine dictum sit, altum sonatur."