git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Check for -amend as a common wrong usage of --amend.

From
Charles Bailey <charles@hashpling.org>
Date
Jan 24, 2008, 19:25 UTC
Message-ID
<20080124192532.GA3389@hashpling.org>
In-Reply-To
<4798DE6A.1050201@obry.net>
On Thu, Jan 24, 2008 at 07:52:26PM +0100, Pascal Obry wrote:
Show 8 quoted lines
> Johannes Schindelin a écrit :
> >That is ugly.  In a source file which is by no means specific to 
> >git-commit, you cannot possibly mean to check for "amend".
> 
> Agreed :( I'll try to come with something better.
> 
> Pascal.
> 
Would this be better handled by a commit-msg hook.  E.g.:
test "$(cat $1)" = "end" && {
    echo >&2 Commit message is \"end\", possible mis-type of --amend
    echo >&2 Use --no-verify to really commit with this commit message
	exit 1
}
Previous: Pascal ObryNext: Pascal Obry
Message 6 of 11 in “Check for -amend as a common wrong usage of --amend.”
  1. Check for -amend as a common wrong usage of --amend.Pascal Obry, Jan 24, 2008
  2. Pascal ObryJan 24, 2008
  3. Jörg SommerJan 26, 2008
  4. Johannes SchindelinJan 24, 2008
  5. Pascal ObryJan 24, 2008
  6. Charles BaileyJan 24, 2008
  7. Pascal ObryJan 24, 2008
  8. Joey HessJan 24, 2008
  9. Junio C HamanoJan 26, 2008
  10. Pierre HabouzitJan 26, 2008
  11. parse-options: catch some likely in presense of aggregated options.Pierre Habouzit, Jan 26, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.